Re: [PATCH 1/3] at91_mci: Enable MMC_CAP_SDIO_IRQ only when itactually works

From: Pierre Ossman
Date: Sun Jul 20 2008 - 07:13:29 EST


On Sun, 20 Jul 2008 10:55:39 +0100
ian <spyro@xxxxxxx> wrote:

> On Sat, 2008-07-19 at 01:01 +0200, Pierre Ossman wrote:
> > > In your opinion, a printed warning that says to be sure to use only
> > > 4-bit mode SDIO cards on slot B... is not acceptable ?
> >
> > It's not really up to the user. The SDIO spec does not mandate 4-bit
> > support, so some cards will not have it.
>
> That seems overly rigid.
>
> its not linux violating the spec, its the SDIO controller in this case.
>
> I see no harm in supporting what the hardware is actually capable of.
>
> It wouldnt be the first bit of broken hardware supported by linux.
>

It does tend to make a mess of things when you start adding up all the
gotchas of each and every broken controller out there (it seems like
every controller decides to violate the spec in their own creative
way).

What about David's idea? Reconfiguring the PIN to be a GPIO pin with an
interrupt shouldn't be that difficult?

Rgds
--
-- Pierre Ossman

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.

Attachment: signature.asc
Description: PGP signature