Re: [PATCH 1/2] PCI Hotplug: acpiphp wants a 64-bit _SUN

From: Jesse Barnes
Date: Tue Dec 16 2008 - 13:51:07 EST


On Thursday, December 11, 2008 11:03 am Matthew Wilcox wrote:
> On Thu, Dec 11, 2008 at 10:35:01AM -0800, Jesse Barnes wrote:
> > On Thursday, December 11, 2008 10:16 am Alex Chiang wrote:
> > > From: Justin Chen <justin.chen@xxxxxx>
> > >
> > > Certain HP machines require the full 64 bits of _SUN as allowed
> > > by the ACPI spec. Without this change, we get name collisions in
> > > the lower 32 bits of the _SUN returned by firmware.
> > >
> > > Signed-off-by: Justin Chen <justin.chen@xxxxxx>
> > > Signed-off-by: Alex Chiang <achiang@xxxxxx>
> >
> > It's very late in the cycle, so I'd like to get acks from at least a
> > couple of other testers for this one... Any volunteers?
>
> Testers or reviewers? Here's my review (done thinking out loud style):

Well, review is good too; I stuffed this one into my for-linus branch (the
whitespace one went into linux-next), thanks for checking it out.

--
Jesse Barnes, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/