Re: [PATCH 2.6.30-rc4] r8169: avoid losing MSI interrupts
From: David Miller
Date: Tue May 26 2009 - 01:55:23 EST
From: David Dillow <dave@xxxxxxxxxxxxxx>
Date: Fri, 22 May 2009 21:29:34 -0400
> The 8169 chip only generates MSI interrupts when all enabled event
> sources are quiescent and one or more sources transition to active. If
> not all of the active events are acknowledged, or a new event becomes
> active while the existing ones are cleared in the handler, we will not
> see a new interrupt.
> The current interrupt handler masks off the Rx and Tx events once the
> NAPI handler has been scheduled, which opens a race window in which we
> can get another Rx or Tx event and never ACK'ing it, stopping all
> activity until the link is reset (ifconfig down/up). Fix this by always
> ACK'ing all event sources, and loop in the handler until we have all
> sources quiescent.
> Signed-off-by: David Dillow <dave@xxxxxxxxxxxxxx>
I've applied this, thanks David.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/