RE: [PATCH] : eliminate code duplication in kernel/tracepoint.c

From: Anirban Sinha
Date: Tue Aug 25 2009 - 10:00:23 EST



>> I still think it's better not to remove this break. every "case"
>> should have a break or a return, expect for the falling throught
>> cases.
>
>Correct. That might seem like a superfluous statement, but when we
>add new cases it stays robust while with the missing break one can
>create an unintended fall-through codepath.
>
> Ingo

Thanks a lot Li and Ingo for all the feedback. Final patch goes below: