Re: [PATCH] vt: make the default cursor shape configurable

From: Daniel Mack
Date: Mon Nov 09 2009 - 13:07:30 EST


On Tue, Nov 10, 2009 at 04:28:03AM +1030, David Newall wrote:
> Daniel Mack wrote:
> > I had that previously and the response was that there is no reason to
> > define that setting per-boot process, as it is rather unlikely that you
> > want to change it from one boot to the next. Hence, it should be set at
> > compile time.
> >
>
> It should be set as a boot parameter, since this is fixed at system
> installation and then left untouched.

I'd be fine with either way. As long as it disables the blinking cursor.

> It seems like adding cruft to the kernel that is just as effectively
> available at run-time. Where does it end? Do we eventually add bash to
> the kernel?

Well, all I need is a way to disable the cursor at boot time, as we
don't want it to be in our boot screen on a embedded system. It is not
only ruin the aesthetics but also gives the wrong assumption that the
system awaits input. There is no userspace at this point, so that's no
option.

My first approach was adding a __setup variable to select that, but it
wasn't beloved by the people get_maintainer.pl spit out. So I made it
compile-time definable, and Clemens extended that to a more powerful
interface of settings.

I don't really have a strong opinion on which way to go, all I need is a
cursor-free system startup :) And I would of course prefer that patch to
be in mainline.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/