Re: [PATCH] vt: make the default cursor shape configurable

From: Daniel Mack
Date: Mon Nov 09 2009 - 17:09:53 EST


On Tue, Nov 10, 2009 at 04:28:03AM +1030, David Newall wrote:
> Daniel Mack wrote:
> > And even if the cursor behaviour is changable at runtime, I don't see
> > why it shouldn't have a selectable compile time default. Which is what
> > the patch adds.
>
>
> It seems like adding cruft to the kernel that is just as effectively
> available at run-time. Where does it end? Do we eventually add bash to
> the kernel?

One more thing:

Clemens' last patch didn't add anything to the kernel's binary size.
It didn't slow down anything either, as there is no run-time condition
evaluation. It just makes something configurable which was hard
coded before. So where's the cruft?

The comparison to 'bash in the kernel' is really inappropriate.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/