[PATCH RFC] Codingstyle: allow omitting braces for all single statement branches

From: Uwe Kleine-KÃnig
Date: Thu Nov 26 2009 - 04:27:30 EST


Grepping for "} else$" in v2.6.32-rc8 yields 6440 hits. So this seems
to be common practice and should be allowed. checkpatch doesn't warn
about both variants.

Signed-off-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>
Cc: Junio C Hamano <gitster@xxxxxxxxx>
Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
Cc: Teemu Likonen <tlikonen@xxxxxx>
Cc: Jiri Kosina <jkosina@xxxxxxx>
Cc: Dan Carpenter <error27@xxxxxxxxx>
Cc: Martin Olsson <martin@xxxxxxxxxx>
Cc: linux-doc@xxxxxxxxxxxxxxx
---
Documentation/CodingStyle | 26 +++++++++++++++++---------
1 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
index 8bb3723..84563c6 100644
--- a/Documentation/CodingStyle
+++ b/Documentation/CodingStyle
@@ -168,15 +168,23 @@ Do not unnecessarily use braces where a single statement will do.
if (condition)
action();

-This does not apply if one branch of a conditional statement is a single
-statement. Use braces in both branches.
-
-if (condition) {
- do_this();
- do_that();
-} else {
- otherwise();
-}
+If not all branches of a conditional statement are single statements you might
+use braces for both branches.
+
+ if (condition) {
+ do_this();
+ do_that();
+ } else
+ otherwise();
+
+or
+
+ if (condition) {
+ do_this();
+ do_that();
+ } else {
+ otherwise();
+ }

3.1: Spaces

--
1.6.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/