Re: [PATCH RFC] Codingstyle: allow omitting braces for all singlestatement branches

From: Peter Zijlstra
Date: Thu Nov 26 2009 - 09:53:27 EST


On Thu, 2009-11-26 at 10:26 +0100, Uwe Kleine-KÃnig wrote:

> -This does not apply if one branch of a conditional statement is a single
> -statement. Use braces in both branches.
> -
> -if (condition) {
> - do_this();
> - do_that();
> -} else {
> - otherwise();
> -}
> +If not all branches of a conditional statement are single statements you might
> +use braces for both branches.
> +
> + if (condition) {
> + do_this();
> + do_that();
> + } else
> + otherwise();
> +
> +or
> +
> + if (condition) {
> + do_this();
> + do_that();
> + } else {
> + otherwise();
> + }
>
> 3.1: Spaces

Andrew recently objected to this pattern, and I tend to agree with him
although I might be guilty of a few such cases myself.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/