Re: [PATCH -mmotm 3/3] memcg: dirty pages instrumentation

From: Daisuke Nishimura
Date: Tue Mar 02 2010 - 03:15:21 EST


On Tue, 2 Mar 2010 09:01:58 +0100, Andrea Righi <arighi@xxxxxxxxxxx> wrote:
> On Tue, Mar 02, 2010 at 09:23:09AM +0900, KAMEZAWA Hiroyuki wrote:
> > On Mon, 1 Mar 2010 22:23:40 +0100
> > Andrea Righi <arighi@xxxxxxxxxxx> wrote:
> >
> > > Apply the cgroup dirty pages accounting and limiting infrastructure to
> > > the opportune kernel functions.
> > >
> > > Signed-off-by: Andrea Righi <arighi@xxxxxxxxxxx>
> >
> > Seems nice.
> >
> > Hmm. the last problem is moving account between memcg.
> >
> > Right ?
>
> Correct. This was actually the last item of the TODO list. Anyway, I'm
> still considering if it's correct to move dirty pages when a task is
> migrated from a cgroup to another. Currently, dirty pages just remain in
> the original cgroup and are flushed depending on the original cgroup
> settings. That is not totally wrong... at least moving the dirty pages
> between memcgs should be optional (move_charge_at_immigrate?).
>
FYI, I'm planning to add file-cache and shmem/tmpfs support for move_charge feature
for 2.6.35.
But, hmm, it would be complicated if we try to move dirty account too.


Thanks,
Daisuke Nishimura.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/