Re: [GIT PULL] Squashfs updates for 2.6.34
From: Phillip Lougher
Date: Wed Mar 03 2010 - 20:16:54 EST
Linus Torvalds wrote:
Please. Don't add more ugly generic header files into the main include
directory. I realize that the ugliness is partly historical (that
"<linux/decompress/mm.h>" file sure as hell was messy to begin with), but
this just makes that crazy situation worse.
Clean up the mess instead of making it even less understandable. Please.
That whole "#ifdef STATIC" crap needs to go - not get spread out even
OK. The decompressor code (inflate/bunzip/lzma) is a "pile
of crap" and mm.h more so. In the past six months I've fixed a lot
of truly bad problems with that code (NULL pointers, buffer over-runs etc.).
In my defence with these patches I was trying for the best solution while
touching as little of the mess as possible. As that's not acceptable, I'll
go away and try and fix some of the mess, before trying for another merge.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/