Re: [PATCH 2/2] device.h drivers/base/core.c Convert dev_<level>macros to functions

From: Andrew Morton
Date: Thu Mar 04 2010 - 20:00:43 EST

On Thu, 4 Mar 2010 16:56:09 -0800 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Wed, 3 Mar 2010 22:27:23 -0800 Joe Perches <joe@xxxxxxxxxxx> wrote:
> > Save ~60k in a defconfig
> >
> > Use %pV and struct va_format
> > Format arguments are verified before printk
> Well that doesn't work very well.
> drivers/net/pcmcia/pcnet_cs.c:117: error: 'dev_info' redeclared as different kind of symbol
> include/linux/device.h:645: error: previous declaration of 'dev_info' was here
> there are lots of other dev_info's which will fail plus perhaps
> dev_err's, etc.

btw, this may be kludgeable aroundable by doing

int _dev_info(const struct device *dev, const char *fmt, ...);

#define dev_info(...) _dev_info(...)

which will use the preprocessor's separation of `foo' from `foo()' to
fix things up.

But it would be better to rename all those dev_info's to device_info or
whatever, IMO.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at