Re: [PATCH 06/18] sched: Generate trace points only if schedulertracing is enabled

From: Frederic Weisbecker
Date: Tue Mar 23 2010 - 20:31:19 EST


On Tue, Mar 23, 2010 at 07:52:01PM -0400, Steven Rostedt wrote:
> On Tue, 2010-03-23 at 02:07 +0100, Frederic Weisbecker wrote:
> > On Tue, Mar 23, 2010 at 01:32:08AM +0100, Jan Kara wrote:
> > > CC: Ingo Molnar <mingo@xxxxxxx>
> > > CC: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > > Signed-off-by: Jan Kara <jack@xxxxxxx>
> > > ---
> >
> >
> > Note this one is an exception.
> > Once tracing is enabled, we need the context switch
> > tracer anyway to keep track of the pid:cmdline mappings.
> >
> >
>
> Yes, the scheduling tracepoints are needed by several tracers. This must
> be enabled by all.
>
> But then again, I'm thinking it would be nicer to find a way to lower
> the impact than just turning them off.
>
> Perhaps only allow the individual disabling if CONFIG_EMBEDDED is set.


Yeah agreed!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/