Re: [PATCHv4 1/2] usb: gadget: storage: strict coversion of 'ro'parameter

[MichaÅ Nazarewicz]

> On Thu, 22 Jul 2010, Andy Shevchenko wrote:
> > @@ -735,8 +735,8 @@ static ssize_t fsg_store_ro(struct device *dev, struct device_attribute *attr,
> >  		LDBG(curlun, "read-only status change prevented\n");
> >  		rc = -EBUSY;
> >  	} else {
> > -		curlun->ro = !!i;
> > -		curlun->initially_ro = !!i;
> > +		curlun->ro = ro;
> > +		curlun->initially_ro = ro;
> >  		LDBG(curlun, "read-only status set to %d\n", curlun->ro);
> >  	}
> >  	up_read(filesem);

On Thu, 22 Jul 2010 16:07:14 +0200, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> Strictly speaking, this changes the behavior when a non-binary value is
> specified.  For example, if somebody were to write "10" then the old
> code would set the value to True and the new code would set the value
> to False -- and neither would reject it as they probably should.
> That's okay; people who write ambiguous or invalid values deserve what
> they get.

If anyone considers that an issue, it would be solved by:

+		curlun->ro = !!ro;
+		curlun->initially_ro = !!ro;

The "!!" where there for that purpose in the first place.

--
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  MichaÅ "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/