Re: [PATCH] regulator: max8660 - fix a memory leak inmax8660_remove()

From: Wolfram Sang
Date: Fri Aug 06 2010 - 04:42:43 EST

On Fri, Aug 06, 2010 at 01:35:27PM +0800, Axel Lin wrote:
> In max8660_probe(), we allocate memory for max660.

Typo: max8660

> In max8660_remove(), current implementation only free rdev
> which is a member of struct max8660.
> Thus, there is a small memory leak when we unload the module.
> This patch fixes the memory leak by passing max660 to i2c clientdata,
> and properly kfree(max8660) in max8660_remove().

These two lines could go away IMHO as they are directly visible from the
code. Still, no real need for a resend from my side.

> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>

Acked-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>

Thanks for catching that!

Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | |

Attachment: signature.asc
Description: Digital signature