Re: [PATCH 2/2 v2] usb gadget: don't save bind callback in structusb_configuration
From: MichaÅ Nazarewicz
Date: Fri Aug 06 2010 - 04:45:27 EST
On Fri, 06 Aug 2010 00:34:35 +0200, Greg KH <greg@xxxxxxxxx> wrote:
On Thu, Aug 05, 2010 at 11:50:17AM +0200, Uwe Kleine-KÃnig wrote:
The bind function is most of the time only called at init time so there is no
need to save a pointer to it in the configuration structure.
This fixes many section mismatches reported by modpost.
Signed-off-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>
Cc: MichaÅ Nazarewicz <m.nazarewicz@xxxxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>
changes since v1:
I'm confused, can you resend what you want me to apply please?
Do I need to drop MichaÅ's patch before applying yours?
Yep. Uwe's patches seem to be a better solution for fixing the section
mismatch. They remove the need of __ref* tags. I looked through them
and they seem fine to me.
(Also, as I realised a minute ago, my patch is incorrect.)
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, MichaÅ "mina86" Nazarewicz (o o)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/