Re: [PATCH] regulator: wm831x-ldo - fix the logic to setREGULATOR_MODE_IDLE and REGULATOR_MODE_STANDBY modes

[Mark Brown]

On Mon, Sep 06, 2010 at 04:48:13PM +0800, Axel Lin wrote:
> Problem description in current implementation:
> When setting REGULATOR_MODE_IDLE mode, current implementation set
> WM831X_LDO1_LP_MODE bit of ctrl_reg (which is wrong, it should clear the bit).

Again, it would be really helpful if you could make your analysis
clearer - at no point do you explain why you think the chip settings
that result from your changes are correct.  Your message explains that
the status readback differs from the settings but it doesn't explain how
you know which bit of code is correct.  This means that your messages
set off alarm bells as it looks like you're just guessing about what
needs to be done to the chip.

In this case your patch appears to be OK so:

Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/