RE: One (possible) x86 get_user_pages bug
From: Kaushik Barde
Date: Sun Jan 30 2011 - 17:26:35 EST
I agree i.e. deviation from underlying arch consideration is not a good
Also, agreed, hypervisor knows which page entries are ready for TLB flush
But, using above knowledge, along with TLB flush based on IPI is a better
solution. Its ability to synchronize it with pCPU based IPI and TLB flush
across vCPU. is key.
IPIs themselves should be in few hundred uSecs in terms latency. Also, why
should pCPU be in sleep state for active vCPU scheduled page workload?
From: Avi Kivity [mailto:avi@xxxxxxxxxx]
Sent: Sunday, January 30, 2011 5:02 AM
To: Jeremy Fitzhardinge
Cc: Jan Beulich; Xiaowei Yang; Nick Piggin; Peter Zijlstra;
fanhenglong@xxxxxxxxxx; Kaushik Barde; Kenneth Lee; linqaingmin;
wangzhenguo@xxxxxxxxxx; Wu Fengguang; xen-devel@xxxxxxxxxxxxxxxxxxx;
linux-kernel@xxxxxxxxxxxxxxx; Marcelo Tosatti
Subject: Re: One (possible) x86 get_user_pages bug
On 01/27/2011 08:27 PM, Jeremy Fitzhardinge wrote:
> And even just considering virtualization, having non-IPI-based tlb
> shootdown is a measurable performance win, since a hypervisor can
> optimise away a cross-VCPU shootdown if it knows no physical TLB
> contains the target VCPU's entries. I can imagine the KVM folks could
> get some benefit from that as well.
It's nice to avoid the IPI (and waking up a cpu if it happens to be
asleep) but I think the risk of deviating too much from the baremetal
arch is too large, as demonstrated by this bug.
(well, async page faults is a counterexample, I wonder if/when it will
error compiling committee.c: too many arguments to function
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/