Re: [build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1
From: Mark Brown
Date: Mon Mar 21 2011 - 12:58:35 EST
On Mon, Mar 21, 2011 at 05:49:37PM +0100, Ingo Molnar wrote:
> * Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > That's because the driver code is trivially broken, though - the build
> > test has identified a flaw in the driver which we should fix.
> Trivially broken how? Your mail in the original thread, if i read it right,
> only claimed that it depends on CONFIG_REGULATOR being present while ideally it
> should be invariant to the value of CONFIG_REGULATOR:
That's the breakage, yes. It should be very straightforward to make the
driver build no matter how CONFIG_REGULATOR is set.
> | Since the regulator on the device is optional this isn't the best fix, the
> | code should be updated to support building without regulator.
> If there is some *other* bug there as well then of course it should be fixed
> instead of worked around.
There's no other bug relevant to this issue.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/