Re: [build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1
From: Ingo Molnar
Date: Mon Mar 21 2011 - 12:49:56 EST
* Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Mar 21, 2011 at 05:11:02PM +0100, Ingo Molnar wrote:
> > * Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > > As indicated that's not a good fix since the affected code is all runtime
> > > conditional already. [...]
> > Well, AFAICS Randy's patch correctly expresses current infrastructure
> > dependencies the driver has.
> That's because the driver code is trivially broken, though - the build
> test has identified a flaw in the driver which we should fix.
Trivially broken how? Your mail in the original thread, if i read it right,
only claimed that it depends on CONFIG_REGULATOR being present while ideally it
should be invariant to the value of CONFIG_REGULATOR:
| Since the regulator on the device is optional this isn't the best fix, the
| code should be updated to support building without regulator.
If there is some *other* bug there as well then of course it should be fixed
instead of worked around.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/