Re: getter PTRACE_GETSIGINFO should not modify anything [Re:[PATCH 11/11] ptrace: implement group stop notification for ptracer]
From: Tejun Heo
Date: Mon May 16 2011 - 04:43:59 EST
On Sun, May 15, 2011 at 10:06:54PM +0200, Jan Kratochvil wrote:
> You are introducing new API which requires new codepaths in every
> debugger-like program using it. I do not find the "not deviating" reason as
> valid for making the _new_ API parts needlessly imperfect. Otherwise in the
> next step we will want to fix the new imperfect parts and - there will be
> three APIs that time to be supported in each debugger-like program depending
> on how old kernel versions the debugger wants to support.
There's distinction between "broken" and "ugly". If it's ugly but
functional, you don't need to "fix" it. What we have is a broken ugly
one and my primary goal is fixing the broken part. I don't
necessarily object to making it pretty but that's not my primary goal.
> Sure the changes should be still small - I do not ask for making unrelated new
> changes; just making the already needed changes perfect in their scope.
Perfect is enemy of good. I'll listen to your and other's suggestions
but given the rather subpar history of ptrace and its development am
not too convinced that the existing ideas or directions were
Frankly, I think the biggest disease was this obsession with
perfection. Whether ptrace is slightly prettier or not, or whether it
can do the obscure feature three enterprise customers requested
doesn't matter all that much. Let's leave them alone and concentrate
on fixing mainstream use cases.
So, I'm gonna push back quite a bit unless it actually compromises
functionality or correctness.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/