Re: [PATCH 1/2] of: fix race when matching drivers

From: Greg KH
Date: Wed May 18 2011 - 16:00:32 EST

On Wed, May 18, 2011 at 01:21:00PM -0600, Grant Likely wrote:
> From: Milton Miller <miltonm@xxxxxxx>
> If two drivers are probing devices at the same time, both will write
> their match table result to the dev->of_match cache at the same time.
> Only write the result if the device matches.
> In a thread titled "SBus devices sometimes detected, sometimes not",
> Meelis reported his SBus hme was not detected about 50% of the time.
> >From the debug suggested by Grant it was obvious another driver matched
> some devices between the call to match the hme and the hme discovery
> failling.
> Reported-by: Meelis Roos <mroos@xxxxxxxx>
> Signed-off-by: Milton Miller <miltonm@xxxxxxx>
> [grant.likely: modified to only call of_match_device() once]
> Signed-off-by: Grant Likely <grant.likely@xxxxxxxxxxxx>

Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at