Re: [PATCH 1/2] staging: iio replaced kmalloc with local variables.

From: Greg KH
Date: Mon Jun 06 2011 - 17:56:21 EST


On Tue, Jun 07, 2011 at 12:37:37AM +0530, anish wrote:
> From: anish kumar <anish198519851985@xxxxxxxxx>
>
> Replace kmalloc with local variables as it was un-necessary and
> also removed the redudant code after this change.

No, it was necessary, you just broke this driver on ARM-based systems,
which isn't nice at all :(

SPI data, like USB data, has to come from kmalloced data, not from the
stack, or bad things can, and will, happen.

So I can't accept this patch, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/