Re: [PATCH 8/9] x86/amd-iommu: Search for existind dev_data beforeallocting a new one

From: Roedel, Joerg
Date: Sat Jun 11 2011 - 06:29:57 EST


On Fri, Jun 10, 2011 at 04:52:26PM -0400, Chris Wright wrote:
> * Joerg Roedel (joerg.roedel@xxxxxxx) wrote:
> > +static struct iommu_dev_data *search_dev_data(u16 devid)
> > +{
> > + struct iommu_dev_data *dev_data;
> > + unsigned long flags;
> > +
> > + spin_lock_irqsave(&dev_data_list_lock, flags);
> > + list_for_each_entry(dev_data, &dev_data_list, dev_data_list) {
> > + if (dev_data->devid == devid)

Right, multiple segments are not handled at all by the driver. The ACPI
tables support them in theory, but there are no systems to test those
things on.

Joerg

--
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/