Re: [PATCH v3 7/9] KVM-GST: KVM Steal time accounting

From: Glauber Costa
Date: Thu Jun 30 2011 - 22:53:36 EST


On 06/30/2011 06:54 PM, Peter Zijlstra wrote:
On Wed, 2011-06-29 at 11:29 -0400, Glauber Costa wrote:
+ if (static_branch(&paravirt_steal_enabled)) {

How is that going to compile on !CONFIG_PARAVIRT or !x86 in general?
Only x86-PARAVIRT will provide that variable.



Good point. I'd wrap it into CONFIG_PARAVIRT.
To be clear, the reason I did not put it inside CONFIG_PARAVIRT_TIME_ACCOUNTING, is because I wanted to have the mere display of steal time separated from the rest - unless, of course, you object this idea.

Using CONFIG_PARAVIRT achieves this goal well.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/