Re: [PATCH] ext2: Don't export ext2_mask_flags() to user space

From: Al Viro
Date: Sat Mar 24 2012 - 04:38:32 EST

On Sat, Mar 24, 2012 at 02:50:38AM -0400, Mike Frysinger wrote:

> > and that's it. ??blackfin and do_mounts_rd are doing the same thing (blackfin -
> > buggy, AFAICS).
> buggy how ? they're not exactly the same as the Blackfin code is
> setting things up for the uClinux MTD map. it isn't parsing the
> filesystem itself (ignoring the size extraction from the superblock).

Compare and you'll see... Block size on ext2 may be bigger than 1Kb;
->s_log_block_size gives the shift (1Kb -> 0, 2Kb -> 1, etc.) Offset
0x18 in superblock, __le32...

Anyway, I've pushed that into vfs.git#master along with other minor stuff
right now; the last 5 commits in there are handling of ext2 and ext3 headers,
starting with "ext2: No longer export ext2_fs.h to user space" by
Thierry Reding, with the next 3 after it doing the move and trimming...
Should propagate to in a few.

I've left the nfsd mess alone for now; it's too ugly to live, but I don't
want to trigger the bikeshedding from hell that happens every time somebody
brings pathconf() up. Not worth bothering with, just to move two macros to
fs/ext2/ext2.h where they really belong...
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at