Re: [PATCH] perf bench: fix confused variable namings and descriptions in mem subsystem

From: Namhyung Kim
Date: Sun Jul 01 2012 - 21:34:41 EST


On Mon, 2 Jul 2012 00:06:23 +0900, Hitoshi Mitake wrote:
> As Namhyung Kim pointed, there are confused namings and descriptions
> of words "cycle" and "clock" in mem-memset.c and mem-memcpy.c.
> With the option "-c" (or "--clock", now renamed as "--cycle"), mem
> subsystem measures cost of memset() and memcpy() with cpu-cycles
> event.
> But current mem subsystem source code contains lots of confused
> variable namings and descriptions with "clock" (e.g. the variable
> use_clock). This is a very bad style because there is another software
> event named "cpu-clock". This patch replaces wrong usage of "clock" to
> "cycle".

Could you fix the Documentation/perf-bench.txt also?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at