Re: [PATCH] perf bench: fix confused variable namings and descriptions in mem subsystem
From: Hitoshi Mitake
Date: Mon Jul 02 2012 - 05:06:21 EST
Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>On Mon, 2 Jul 2012 00:06:23 +0900, Hitoshi Mitake wrote:
>> As Namhyung Kim pointed, there are confused namings and descriptions
>> of words "cycle" and "clock" in mem-memset.c and mem-memcpy.c.
>> With the option "-c" (or "--clock", now renamed as "--cycle"), mem
>> subsystem measures cost of memset() and memcpy() with cpu-cycles
>> But current mem subsystem source code contains lots of confused
>> variable namings and descriptions with "clock" (e.g. the variable
>> use_clock). This is a very bad style because there is another
>> event named "cpu-clock". This patch replaces wrong usage of "clock"
>Could you fix the Documentation/perf-bench.txt also?
Oops, sorry. I'll send the modified version later.
Sent from my Android phone with K-9. Please excuse my brevity.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/