Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP moduledependency.

From: David Miller
Date: Tue Oct 16 2012 - 16:17:13 EST

From: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx>
Date: Tue, 16 Oct 2012 21:09:27 +0100

> I think the various kconfig options should be changed as follows:
> 1. Only PTP_1588_CLOCK selects PPS.
> 2. Nothing depends on EXPERIMENTAL. (This stuff has been in for 18
> months and it's even being backported to RHEL 6 now.)
> 3. Either:
> (a) The per-driver PHC options select nothing, and the driver options
> do e.g.:
> select PTP_1588_CLOCK if IGB_PTP
> (b) The per-driver PHC options are removed and the driver options do:
> select PTP_1588_CLOCK
> (i.e. PHC support is unconditional)
> Any objections to this, or preference for (a) vs (b)?

No objections, prefer (b).
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at