RE: [PATCH 1/2] Fix build error caused by broken PCH_PTP moduledependency.
From: Keller, Jacob E
Date: Tue Oct 16 2012 - 17:08:17 EST
> -----Original Message-----
> From: netdev-owner@xxxxxxxxxxxxxxx [mailto:netdev-owner@xxxxxxxxxxxxxxx]
> On Behalf Of David Miller
> Sent: Tuesday, October 16, 2012 1:17 PM
> To: bhutchings@xxxxxxxxxxxxxx
> Cc: richardcochran@xxxxxxxxx; haicheng.li@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; tshimizu818@xxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; haicheng.lee@xxxxxxxxx
> Subject: Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module
> From: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx>
> Date: Tue, 16 Oct 2012 21:09:27 +0100
> > I think the various kconfig options should be changed as follows:
> > 1. Only PTP_1588_CLOCK selects PPS.
> > 2. Nothing depends on EXPERIMENTAL. (This stuff has been in for 18
> > months and it's even being backported to RHEL 6 now.)
> > 3. Either:
> > (a) The per-driver PHC options select nothing, and the driver options
> > do e.g.:
> > select PTP_1588_CLOCK if IGB_PTP
> > (b) The per-driver PHC options are removed and the driver options do:
> > select PTP_1588_CLOCK
> > (i.e. PHC support is unconditional)
> > Any objections to this, or preference for (a) vs (b)?
> No objections, prefer (b).
No objections here, I also prefer (b). The feature shouldn't have much impact unless enabled via hwtstamp_ioctl, and it drastically reduces requirement on end-user needing to enable PHC support.
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/