Re: [PATCH V3 1/2] mfd: add TI TPS80031 mfd core driver

[Laxman Dewangan]

On 11/13/2012 09:45 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, Nov 13, 2012 at 09:35:45PM -0500, Laxman Dewangan wrote:
>
> > Yes, this is not a good idea, We will need support for wakeup
> > without wakeup registers.
> > Probably we need to add one more parameter, wake enable to control
> > without wake_base.
> This does not seem sensible.  Why would this be optional if it is
> useful?  In any case, what you're doing in the driver here is clearly
> not the way forward.

I was thinking  of adding wake_enable in struct regmap_irq_chip and 
decide the wake support based on the value if wake_enable true or 
wake_base is non-zero. then wake support should be enable.
The wake register write will happen only when wake_base is non-zero.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/