Re: Use PCI ROMs from EFI boot services

From: Bjorn Helgaas
Date: Thu Dec 06 2012 - 16:44:27 EST

On Thu, Dec 6, 2012 at 11:54 AM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:
> On Thu, Dec 06, 2012 at 10:26:01AM -0800, H. Peter Anvin wrote:
>> NAK on this bit:
>> + if (boot_params.hdr.version < 0x0209)
>> + return 0;
>> This field is kernel->bootloader documentation. If a nonmaching
>> value somehow leaks into the kernel, the kernel could either
>> panic("Bootloader written by moron") or it should clear some fields,
>> but littering the kernel with these kinds of tests is just plain
>> braindead.
> Dropping that should be fine. Bjorn, would you prefer a patch from me to
> do that?

I dropped that check and re-pushed my -next branch.

Yinghai, I don't understand your pa_data_setup_pci.patch, but if
somebody else acks it and we can come up with an intelligible
changelog, I'll fold that in, too.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at