Re: [PATCH 1/2] staging/comedi: Add pci_driver.name to skel driver

From: Peter Hüwe
Date: Mon Jan 21 2013 - 16:22:10 EST


Am Montag, 21. Januar 2013, 21:56:22 schrieb H Hartley Sweeten:
> On Monday, January 21, 2013 1:52 PM, Peter Huewe wrote:
> > This patch adds the comedi_driver.name to pci_driver.name
> > to the skel driver, so we can remove the workaround in drivers.c
> >
> > Signed-off-by: Peter Huewe <peterhuewe@xxxxxx>
> > ---
> >
> > drivers/staging/comedi/drivers/skel.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/staging/comedi/drivers/skel.c
> > b/drivers/staging/comedi/drivers/skel.c index e2d7970..4a40498 100644
> > --- a/drivers/staging/comedi/drivers/skel.c
> > +++ b/drivers/staging/comedi/drivers/skel.c
> > @@ -713,6 +713,7 @@ static void skel_pci_remove(struct pci_dev *dev)
> >
> > }
> >
> > static struct pci_driver skel_pci_driver = {
> >
> > + .name = "dummy"
> >
> > .id_table = skel_pci_table,
> > .probe = &skel_pci_probe,
> > .remove = &skel_pci_remove
>
> Hmm... I was just about to post a rebase of the last part of my drivers.c
> cleanup that included this and your 2/2 patch.
>
> Oh well... Rebase again...
>
> FWIW, for both patches.
>
> Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

It's okay to drop my patches so you don't have to rebase.

(I posted a version with the missing comma nevertheless)


Thanks,
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/