Re: [PATCH 1/1] Introduce Intel RAPL cooling device driver

[Jacob Pan]

On Tue, 2 Apr 2013 16:00:42 -0700
Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> > +#include "intel_rapl.h"
> > +#include "../../../fs/sysfs/sysfs.h"  
> 
> WTF?
> 
> Oh, that's a sure sign you are not doing something properly, if you
> think it's ok to muck around with the internals of sysfs.
> 
> There's a reason that file is "private", why do you think it's ok to
> use it directly?  Did you just think that I somehow "forgot" to put
> it in the proper include directory?
I did feel unsure about this but i saw some precedence in the kernel.
Anyway, I needed a way to validate a userspace file passed to rapl
driver belong to the same sysfs directory. I will look for alternative
ways.

-- 
Thanks,

Jacob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/