Re: [PATCH v3 1/8] video: xilinxfb: Fix OF probing on little-endiansystems

From: Timur Tabi
Date: Fri May 31 2013 - 09:05:21 EST


On 05/31/2013 07:55 AM, Michal Simek wrote:
> - p = (u32 *)of_get_property(op->dev.of_node, "xlnx,dcr-splb-slave-if", NULL);
> - tft_access = p ? *p : 0;
> + of_property_read_u32(op->dev.of_node, "xlnx,dcr-splb-slave-if",
> + &tft_access);

This is okay, but just FYI, you could instead have just used be32_to_cpup().

--
Timur Tabi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/