Re: [PATCH] Modify UEFI anti-bricking code

From: joeyli
Date: Wed Jun 05 2013 - 22:25:50 EST

æ äï2013-06-05 æ 16:08 +0000ïMatthew Garrett æåï
> On Wed, 2013-06-05 at 16:59 +0100, Matt Fleming wrote:
> > + /* clean DUMMY object */
> > + efi.set_variable(efi_dummy_name, &EFI_DUMMY_GUID, 0, 0, NULL);
> Hm. Actually, is that going to work? From the spec:

The patch I tested on OVMF, it can delete DUMMY object when system boot.

> If a preexisting variable is rewritten with different attributes,
> SetVariable()shall not modify the variable and shall return
> So I think we probably need to fix the attributes to NV|RT|BS for both
> this call and the one in query_variable_store. We should probably also
> only do the workaround if the NV bit is set in the original query.
> --
> Matthew Garrett | mjg59@xxxxxxxxxxxxx

Yes, I think that more safe for fix the attributes.

Thanks a lot!
Joey Lee

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at