Re: [PATCH v2 1/4] mfd: Kontron PLD mfd driver

From: Mark Brown
Date: Wed Jun 19 2013 - 05:49:24 EST

On Wed, Jun 19, 2013 at 11:11:27AM +0200, Samuel Ortiz wrote:
> On Wed, Jun 19, 2013 at 10:40:04AM +0200, Linus Walleij wrote:

> > Not really my business, but I think if I was to implement this
> > inter-module API I would use regmap for this read/write marshalling
> > right here.

> I thought about this one and was under the impression that the regmap
> API would not let us implement this kind of stuff. I don't see how the
> reg_read and reg_write hooks would allow us to implement that, but I may
> be missing something here. Maybe Mark can provide some more input.

You should be able to use reg_read() and reg_write() but you're right it
would be a bit hoop jumping. Really the code looks like a new generic
bus type for ioread()/iowrite() users though - I guess there will be
other similar devices connected in the same way and they probably don't
have radically different ideas about registers.

Attachment: signature.asc
Description: Digital signature