Re: Ugly patches for stolen reservation
From: H. Peter Anvin
Date: Thu Jul 25 2013 - 20:49:18 EST
On 07/25/2013 05:31 PM, Linus Torvalds wrote:
> On Thu, Jul 25, 2013 at 3:42 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
>> So the bootloader is just as likely to step on things... what happens when/if it does?
> This isn't a new problem. We've had this "firmware tables don't show
> all devices" issue before.
Yes, I just want to know what happens.
> The only odd thing about this one is how the quirk in question uses
> "e820_add_region()" instead of just adding things to the MMIO list.
> And I think that's actually likely a mistake.
> So Jesse, why don't you do what the other quirks do, and claim an
> actual MMIO resource? If you make it a real resource, you'll get to
> use fancy things like REAL NAMES, and actually document it. With
> human-readable strings.
> See quirk_io_region() in drivers/pci/quirks.c for example. The same
> code except for IORESOURCE_MEM should do a lovely job..
> And even *if* it's already marked reserved in the e820 table, it just
> looks nice in /proc/iomem.
We should do both -- mark it reserved in early boot, and add it as an
MMIO region later during boot.
The problem here, if I'm reading this right, is that this memory region
is marked as normal RAM in e820, which is much worse than just not
marking it as reserved; we need to intercept this memory before we
genuinely turn it into normal RAM.
At the same time, we have no protection against the bootloader using
this as memory or even placing the kernel there. The BIOS needs to be
fixed regardless of what workarounds we do in the kernel.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/