Re: [PATCH] rcu: Make struct rcu_head searchable

[Paul E. McKenney]

On Wed, Nov 13, 2013 at 12:02:25PM -0500, Steven Rostedt wrote:
> After wasting too much time trying to see where struct rcu_head was
> declared, I finally found it in include/linux/types.h as a define for
> callback_head!
> 
> To prevent other developers from wasting their precious time in
> searching for this structure, add a comment to help them find it!
> 
> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Cc: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Steven "frustrated" Rostedt <rostedt@xxxxxxxxxxx>

The cscope tool is your friend in this case, but nevertheless:

Reviewed-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>

> diff --git a/include/linux/types.h b/include/linux/types.h
> index 4d118ba..073e9a8 100644
> --- a/include/linux/types.h
> +++ b/include/linux/types.h
> @@ -210,6 +210,9 @@ struct callback_head {
>  	struct callback_head *next;
>  	void (*func)(struct callback_head *head);
>  };
> +/*
> + * Make "struct rcu_head {" seachable with this comment.
> + */
>  #define rcu_head callback_head
> 
>  #endif /*  __ASSEMBLY__ */
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/