Re: [PATCH v2] cpufreq: powernow-k8: Suppress checkpatch warnings

From: Rafael J. Wysocki
Date: Mon May 19 2014 - 19:05:37 EST


On Monday, May 12, 2014 09:52:06 AM Viresh Kumar wrote:
> On 11 May 2014 22:56, Stratos Karafotis <stratosk@xxxxxxxxxxxx> wrote:
> > Suppress the following checkpatch.pl warnings:
> >
> > - WARNING: Prefer pr_err(... to printk(KERN_ERR ...
> > - WARNING: Prefer pr_info(... to printk(KERN_INFO ...
> > - WARNING: Prefer pr_warn(... to printk(KERN_WARNING ...
> > - WARNING: quoted string split across lines
> > - WARNING: please, no spaces at the start of a line
> >
> > Also, define the pr_fmt macro instead of PFX for the module name.
> >
> > Signed-off-by: Stratos Karafotis <stratosk@xxxxxxxxxxxx>

Queued up for 3.16, thanks!

> > ---
> >
> > Changes v1 -> v2
> > - Use pr_err_once instead of printk_once
> > - Change missing_pss_msg to macro (because pr_err_once
> > doesn't compile otherwise)
> > - Put one pr_err message in a single line instead of two
> > - Ignore "line over 80 characters" warnings
> > - Change the word "Fix" in the subject of the patch to
> > "Suppress" as the patch doesn't really fix anything
> >
> > drivers/cpufreq/powernow-k8.c | 180 +++++++++++++++++-------------------------
> > drivers/cpufreq/powernow-k8.h | 2 +-
> > 2 files changed, 74 insertions(+), 108 deletions(-)
>
> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/