Re: [PATCH 6/6] ARM: dts: Add tps65090 FETs constraints
From: Mark Brown
Date: Wed Aug 13 2014 - 08:29:47 EST
On Wed, Aug 13, 2014 at 01:31:44PM +0200, Javier Martinez Canillas wrote:
Please fix your mailer to word wrap at less than 80 columns, it makes
your mails very hard to read when replying.
> On 08/12/2014 11:27 PM, Mark Brown wrote:
> > Well, I think the question is if you understand where those numbers come
> > from and if they make sense. I've not seen the schematic for the board
> > so I can't comment but it is quite unusual to see ranges listed for so
> > many supplies, for things like SD it's obviously normal but things like
> > video_mid are a bit more surprising. Does anything actually vary those
> > voltages?
> You are right, in fact even the voltage for the SD supply (tps65090 fet4) does
> not change but still their constraints have to be defined, since it is used as a
> vmmc-supply and the series "Adding UHS support for dw_mmc driver"  calls
> mmc_regulator_get_ocrmask()/mmc_regulator_set_ocr() for mmc->supply.vmmc.
No, that makes no sense. If the voltage isn't allowed to change why
should the constraints be specifying a range of voltages for it to be
set to, especially a range with more than one value in it?
Please try to think about what you're doing in design terms rather than
just bashing on things until you get something that works in your use
case, it's important that things are understandable so that we avoid
fragility and special casing.
> For fixed regulators (like fet4), mmc_regulator_set_ocr() just skips varying the
> regulator voltage but still expects to be able to obtain its voltage.
Which can be done with regulator_get_voltage().
Description: Digital signature