Re: [PATCH net-next 0/4] r8152: firmware support
From: David Miller
Date: Mon Aug 25 2014 - 03:00:31 EST
From: Hayes Wang <hayeswang@xxxxxxxxxxx>
Date: Mon, 25 Aug 2014 06:43:02 +0000
> Except the step 3, 4, 6 and 7, the other steps depend on the
> context of the firmware. That is, for different firmware, some
> actions would be removed or added, and some settings would be
> different. Especially the step 8, it often different for
> different firmwares. Should I add some firmware version check
> in the source code?
This is extremely poor design of the firmware, adding such constantly
changing dependencies and constantly changing programming sequences
just to get the firmare executing is a terrible idea.
You really need to sanitize this in some way, because what you have
posted is totally unacceptable to me.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/