Re: [PATCH RFC] regmap: Split regmap_get_endian() in two functions

From: Stephen Warren
Date: Wed Aug 27 2014 - 12:40:11 EST

On 08/27/2014 08:36 AM, Geert Uytterhoeven wrote:
Split regmap_get_endian() in two functions, regmap_get_reg_endian() and

This allows to:
- Get rid of the three switch()es on "type", incl. error handling in
three "default" cases,
- Get rid of the regmap_endian_type enum,
- Get rid of the non-NULL check of "config" (regmap_init() already
checks for that),
- Get rid of the "endian" output parameters, and just return the
regmap_endian enum value, as the functions can no longer fail.

This saves 21 lines of code (despite the still-present
one-comment-per-line over-documentation), and 30 bytes of code on ARM

For the mailing list record only (since it's been applied),
Reviewed-by: Stephen Warren <swarren@xxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at