Re: [PATCH] Staging: dgnc: Fix long line coding style issues in dgnc_cls.h

From: Valdis . Kletnieks
Date: Wed Dec 03 2014 - 13:18:29 EST


On Wed, 03 Dec 2014 17:07:28 +0000, Sean Cleator said:
> A patch to fix the rest of the long line warnings in the dgnc_cls.h file
> found by the checkpatch.pl tool

> struct cls_uart_struct {
> u8 txrx; /* WR RHR/THR - Holding Reg */
> u8 ier; /* WR IER - Interrupt Enable Reg */
> - u8 isr_fcr; /* WR ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
> + u8 isr_fcr; /*
> + * WR ISR/FCR - Interrupt Status Reg/Fifo
> + * Control Reg
> + */
> u8 lcr; /* WR LCR - Line Control Reg */
> u8 mcr; /* WR MCR - Modem Control Reg */
> u8 lsr; /* WR LSR - Line Status Reg */

It may shut up the warning, but is this really an improvement?

Attachment: pgpPM_vaeqhdO.pgp
Description: PGP signature