Re: [PATCH v3] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros
From: Tristan Lelong
Date: Wed Dec 24 2014 - 08:54:19 EST
On Sat, Dec 06, 2014 at 04:03:22PM -0800, Tristan Lelong wrote:
> This patch fix a sparse warning in lustre sources
> warning: incorrect type in argument 1 (different address spaces)
> expected void [noderef] <asn:1>*to
> got char *<noident>
> This is done by adding the missing __user attribute on userland pointers inside the LPROC_SEQ_FOPS like macros:
> - LPROC_SEQ_FOPS
> - LPROC_SEQ_FOPS_RW_TYPE
> - LPROC_SEQ_FOPS_WR_ONLY
> - LDLM_POOL_PROC_WRITER
> The patch also updates all the functions that are used by this macro:
> - lprocfs_wr_*
> - *_seq_write
> as well as some helpers used by the previously modified functions (otherwise fixing the sparse warning add some new ones):
> - lprocfs_write_frac_helper
> - lprocfs_write_helper
> - lprocfs_write_u64_helper
> The patch also fixes one __user pointer direct dereference by strncmp in function fld_proc_hash_seq_write.
> Signed-off-by: Tristan Lelong <tristan@xxxxxxxxxx>
> Changes in v2:
> Use dynamic allocation for 'name' variable instead of having it on the stack, per Greg K-H suggestion.
> Changes in v3:
> Rename added variable from 'name' to 'fh_name'.
> Revert to a stack declaration of 'fh_name' since it is not 80 bytes but only 8, per Andreas Dilger comment.
I just wanted to follow up on that patch to see if anybody had any comment.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/