Re: [PATCH 1/2] hwrng: iproc-rng200 - Add Broadcom IPROC RNG driver

From: Scott Branden
Date: Sat Feb 14 2015 - 11:37:16 EST

Hi Joe,

I really don't see the missing terminating newlines in the patch or source code. The lines look the same as every other line???


On 15-02-09 04:27 PM, Joe Perches wrote:
On Mon, 2015-02-09 at 16:07 -0800, Scott Branden wrote:
This adds a driver for random number generator present on Broadcom
IPROC devices.


diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c
+static int iproc_rng200_probe(struct platform_device *pdev)
+ if (!res) {
+ dev_err(dev, "failed to get rng resources");

Missing terminating newline:

dev_err(dev, "failed to get rng resources\n");

+ rng_base = devm_ioremap_resource(dev, res);
+ if (!rng_base) {
+ dev_err(dev, "failed to remap rng regs");

here too.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at