Re: [PATCH 0/3] perf tools: Adding xz decompression support

From: Namhyung Kim
Date: Tue Mar 03 2015 - 21:06:05 EST


On Tue, Mar 03, 2015 at 04:29:27PM +0100, Jiri Olsa wrote:
> hi,
> adding support to decompress kernel modules on Fedora 21
> (lzma compression) vaguely continuing in previous RFC:
> http://marc.info/?l=linux-kernel&m=142261340327588&w=2
>
> I'm basically extending he decompression framework Namhyung
> introduced earlier plus other fixes for kernel modules dso
> objects handling.
>
> Last patch adds decompression support to annotate command, so
> it now displays annotation for compressed kernel modules.

Nice work! I went through the patches and liked the kmod_path__parse
change. :) Please feel free to add my Ack's to this series when you
send v2.

Thanks,
Namhyung


>
> Current work available at:
> git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
> perf/lzma
>
> thanks,
> jirka
>
>
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Cc: Corey Ashford <cjashfor@xxxxxxxxxxxxxxxxxx>
> Cc: David Ahern <dsahern@xxxxxxxxx>
> Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: Paul Mackerras <paulus@xxxxxxxxx>
> Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Cc: Stephane Eranian <eranian@xxxxxxxxxx>
> ---
> Jiri Olsa (14):
> perf tools: Remove superfluous thread->comm_set setting
> perf tools: Add feature check for lzma library
> perf tools: Add lzma decompression support for kernel module
> perf tools: Add kmod_path__parse function
> perf tools: Add dsos__new function
> perf tools: Add machine__module_dso function
> perf tools: Use kmod_path__parse for machine__new_dso
> perf tools: Use kmod_path__parse in map_groups__set_modules_path_dir
> perf tools: Use kmod_path__parse in decompress_kmodule
> perf tools: Use kmod_path__parse in is_kernel_module
> perf tools: Remove compressed argument from is_kernel_module
> perf tools: Remove is_kmodule_extension function
> perf tools: Try to lookup kernel module map before creating one
> perf annotate: Allow annotation for decompressed kernel modules
>
> tools/perf/Makefile.perf | 2 ++
> tools/perf/config/Makefile | 16 ++++++++--
> tools/perf/config/feature-checks/Makefile | 6 +++-
> tools/perf/config/feature-checks/test-lzma.c | 10 ++++++
> tools/perf/tests/Build | 1 +
> tools/perf/tests/builtin-test.c | 4 +++
> tools/perf/tests/kmod-path.c | 73 ++++++++++++++++++++++++++++++++++++++++++++
> tools/perf/tests/tests.h | 1 +
> tools/perf/util/Build | 1 +
> tools/perf/util/annotate.c | 32 +++++++++++++++++++-
> tools/perf/util/dso.c | 52 ++++++++++++--------------------
> tools/perf/util/dso.h | 4 +--
> tools/perf/util/header.c | 2 +-
> tools/perf/util/lzma.c | 95 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> tools/perf/util/machine.c | 142 +++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------
> tools/perf/util/symbol-elf.c | 25 ++++++++++-----
> tools/perf/util/thread.c | 1 -
> tools/perf/util/util.c | 66 ++++++++++++++++++++++++++++++++++++++++
> tools/perf/util/util.h | 18 +++++++++++
> 19 files changed, 436 insertions(+), 115 deletions(-)
> create mode 100644 tools/perf/config/feature-checks/test-lzma.c
> create mode 100644 tools/perf/tests/kmod-path.c
> create mode 100644 tools/perf/util/lzma.c
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/