Re: [PATCH] ata: add AMD Seattle platform driver
From: Arnd Bergmann
Date: Wed Jan 13 2016 - 15:40:35 EST
On Wednesday 13 January 2016 10:55:04 Brijesh Singh wrote:
> On 01/12/2016 08:24 AM, Arnd Bergmann wrote:
> > c) calling into the ACPI interpreter to do platform specific hacks
> Thanks for explaining. Now I understood your comment on AML however we need to consider the following:
> a) activity LED blinking routines are called very frequent (10 to 100ms based on emp->state) and executing AML method that often would introduces its own overhead.
> b) all BIOS vendors need to implement a new methods in their DSDT and release a new BIOS.
> c) other OS'es (mainly Windows) driver need to be updated.
> We don't know how many other SoC's have similar hacky implementation which can take advantage of extending generic
> AHCI driver to call into AML methods for LED blink. Given some of these causes I think having a platform driver is much cleaner. I can drop DT binding part from this driver and keep just ACPI binding.
> Thoughts ?
I don't care what you do with ACPI, just make sure we can use the generic
driver without any platform specific hacks for the DT case.
For ACPI, please talk to the respective maintainers about whether they want
to have a custom driver for this case, or a proper abstraction in the generic