Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles
From: Chen Gang
Date: Thu Feb 25 2016 - 17:26:12 EST
On 2/26/16 00:07, Mel Gorman wrote:
>>> On Thu, Feb 25, 2016 at 06:26:31AM +0800, chengang@xxxxxxxxxxxxxxxx wrote:
> I do not want this patch to go through the trivial tree. It still adds
> another step to identifying relevant commits through git blame and has
> limited, if any, benefit to maintainability.
>> "it's preferable to preserve blame than go through a layer of cleanup
>> when looking for the commit that defined particular flags".
> git blame identifies what commit last altered a line. If a cleanup patch
> is encountered then the tree before that commit needs to be examined
> which adds time. It's rare that cleanup patches on their own are useful
> and this is one of those cases.
git is a tool mainly for analyzing code, but not mainly for normal
reading main code.
So for me, the coding styles need not consider about git.
Chen Gang (éå)
Managing Natural Environments is the Duty of Human Beings.