Re: [PATCH v1 2/5] perf/x86/intel/pt: IP filtering register/cpuid bits

From: Borislav Petkov
Date: Thu Apr 21 2016 - 16:38:17 EST


On Thu, Apr 21, 2016 at 08:55:38PM +0200, Thomas Gleixner wrote:
> I have to disagree here. The MSRs itself can really go into msr-index.h while
> the bit definitions might go elsewhere. What's wrong with having all MSRs at a
> central place?

Same reason as for pci_ids.h - to contain only MSRs which are used in
multiple compilation units.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.