RE: [PATCH v2] Linux VM workaround for Knights Landing A/D leak

From: Anaczkowski, Lukasz
Date: Wed Jun 15 2016 - 09:12:27 EST


From: Borislav Petkov [mailto:bp@xxxxxxxxx]
Sent: Tuesday, June 14, 2016 8:10 PM

>> + if (boot_cpu_has_bug(X86_BUG_PTE_LEAK))
>
> static_cpu_has_bug()

>> + if (c->x86_model == 87) {
>
> That should be INTEL_FAM6_XEON_PHI_KNL, AFAICT.

>> + static bool printed;
>> +
>> + if (!printed) {
>> + pr_info("Enabling PTE leaking workaround\n");
>> + printed = true;
>> + }
>
> pr_info_once

Thanks, Boris! This is very valuable. I'll address those comments in next version of the patch.

Cheers,
Lukasz